Closed
Bug 729584
Opened 12 years ago
Closed 12 years ago
mozJSComponentLoader::ImportInto needs to wrap exceptions
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(1 file, 1 obsolete file)
1.69 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Only seems to be a problem with compartment-per-global.
Attachment #599653 -
Flags: review?(bobbyholley+bmo)
Updated•12 years ago
|
Assignee: nobody → luke
Assignee | ||
Comment 1•12 years ago
|
||
Oops, the wrong patch.
Attachment #599653 -
Attachment is obsolete: true
Attachment #599678 -
Flags: review?(bobbyholley+bmo)
Attachment #599653 -
Flags: review?(bobbyholley+bmo)
Comment 2•12 years ago
|
||
Comment on attachment 599678 [details] [diff] [review] real patch I don't know this code super well, but this seems fine.
Attachment #599678 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a180e202f229
Target Milestone: --- → mozilla13
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a180e202f229
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
The patch from this bug makes my Mac PPC build of Mozilla 13.0.1 fail with this error message: ./../../dist/include/jsapi.h: In member function ‘nsresult mozJSComponentLoader::ImportInto(const nsACString_internal&, JSObject*, JSContext*, JSObject**)’: ../../../dist/include/jsapi.h:180: error: cannot reload integer constant operand in ‘asm’ Is there any obvious reason? Comment 0 here says that the bug (which I don't understand) is only a problem for cpg that landed for Mozilla 15; can I assume reverting this patch for my PPC compilation is fine?
Comment 6•12 years ago
|
||
(In reply to Florian Quèze from comment #5) > Is there any obvious reason? Given the patch, something to do with the implementation of JS::Anchor, presumably. > Comment 0 here says that the bug (which I don't understand) is only a > problem for cpg that landed for Mozilla 15; can I assume reverting this > patch for my PPC compilation is fine? If you're targeting mozilla 14, sure. (I just noticed that the target milestone for this bug was wrong - it landed mid-february, so it should be FF14). But I think it's generally a better idea to figure out how to make JS::Anchor<jsval> work on your system.
Target Milestone: mozilla13 → mozilla14
Comment 7•12 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #6) > If you're targeting mozilla 14, sure. Thanks. > (I just noticed that the target > milestone for this bug was wrong - it landed mid-february, so it should be > FF14). I'm pulling the mozilla source code from the FIREFOX_13_0_1_RELEASE tag and the patch attached here 'unapplies' cleanly with 'patch -p1 -R' so I think the mozilla13 target milestone was correct. > But I think it's generally a better idea to figure out how to make > JS::Anchor<jsval> work on your system. The reason why I need to maintain PPC support is that the Mac build slave for Instantbird is still an old PPC machine. I hope we will be able to update to some newer hardware and drop PPC support before we update to Mozilla 15 (probably in 10-12 weeks).
Target Milestone: mozilla14 → mozilla13
Comment 8•12 years ago
|
||
(In reply to Florian Quèze from comment #7) > I'm pulling the mozilla source code from the FIREFOX_13_0_1_RELEASE tag and > the patch attached here 'unapplies' cleanly with 'patch -p1 -R' so I think > the mozilla13 target milestone was correct. Doh, I misread the release schedule. Thanks for fixing it. :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•